Skip to content

Revert "[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Revert "[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) #5189

merged 1 commit into from
Oct 28, 2024

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Oct 28, 2024 •
edited by pr-codex bot
Loading

…5186)"

This reverts commit 2bf65c0.

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on removing several components and files related to in-app wallets and analytics, while introducing new functionality for managing embedded wallets, including enhanced navigation and analytics features.

Detailed summary

  • Deleted various files related to in-app wallets and analytics.
  • Added AnalyticsCallout component for displaying wallet usage insights.
  • Updated Layout to include AnalyticsCallout.
  • Introduced EmbeddedWallets component for managing wallet settings and users.
  • Enhanced Page components to handle authentication and API key management.
  • Implemented tab navigation for users and configuration in EmbeddedWallets.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 7:43am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 28, 2024 7:43am
thirdweb_playground ⬜️ Skipped (Inspect) Oct 28, 2024 7:43am
wallet-ui ⬜️ Skipped (Inspect) Oct 28, 2024 7:43am

@changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024

⚠️ No Changeset found

Latest commit: 54bc919

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

[Click here if you're a maintainer who wants to add a changeset to this PR](https://github.com/thirdweb-dev/js/new/joaquim/revert-inapp-analytics?filename=.changeset/happy-tigers-stare.md&value=---%0A%22thirdweb-dashboard%22%3A%20patch%0A---%0A%0ARevert%20%22%5BDashboard%5D%20Feature%3A%20Adds%20analytics%20to%20in-app-wallets%20page%20(%23%E2%80%A6%0A)

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 28, 2024
@joaquim-verges joaquim-verges changed the title Revert "[Dashboard] Feature: Adds analytics to in-app-wallets page (#… Revert "[Dashboard] Feature: Adds analytics to in-app-wallets page (#5186) Oct 28, 2024
@codecov
Copy link

codecov bot commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (84571ef) to head (54bc919).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5189   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1067     1067           
  Lines       55304    55304           
  Branches     3970     3970           
=======================================
  Hits        25054    25054           
  Misses      29557    29557           
  Partials      693      693
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 84571ef
packages 40.31% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.9 KB (0%) 859 ms (0%) 826 ms (+86.74% 🔺) 1.7 s
thirdweb (cjs) 102.73 KB (0%) 2.1 s (0%) 1.4 s (-9.55% 🔽) 3.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 80 ms (+173.47% 🔺) 176 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 24 ms (+106.75% 🔺) 34 ms
thirdweb/react (minimal + tree-shaking) 17.34 KB (0%) 347 ms (0%) 119 ms (-15.07% 🔽) 466 ms

@joaquim-verges joaquim-verges merged commit 83a2412 into main Oct 28, 2024
30 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/revert-inapp-analytics branch October 28, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@MananTank MananTank Awaiting requested review from MananTank

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges